New labeller: label_dictionary()#461
Merged
thomasp85 merged 9 commits intor-lib:mainfrom Oct 22, 2024
Merged
Conversation
Member
|
Still on the fence about the use of "lut". I don't think many users will immediately understand what it does Don't know if |
Contributor
Author
|
I'd be happy to change the name into either of these |
Member
|
I feel we used the |
Contributor
Author
|
In tidyverse/ggplot2#6077, we'd allow |
Member
|
then let's mirror that |
Merge branch 'main' into label_lut # Conflicts: # man/label_parse.Rd # man/label_wrap.Rd
Member
|
also need to rename the test file |
Contributor
Author
|
Good catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #458.
Briefly, you pass a named vector and the breaks will be matched to the names, and the value will be returned as the label.
Examples rendered:
Created on 2024-10-07 with reprex v2.1.1